Inter-sections.net : Array matcher

Comment on Array matcher by Mark Van Holstyn

Mon, 26 Nov 2007 22:42:34 +0000

Not 100% sure I like this more or not, but what about this?

ActionMailer::Base.deliveries.select do |mail| mail.body.match(/#{user.confirmation_code}/) && mail.body.match(/#{user.id}/) end.shouldnot beempty

or, so we don’t do unnecessary checks…

ActionMailer::Base.deliveries.detect do |mail| mail.body.match(/#{user.confirmation_code}/) && mail.body.match(/#{user.id}/) end.shouldnot benil

Comment on Array matcher by daniel

Mon, 26 Nov 2007 22:49:44 +0000

Interesting :-) Another twist on the approach.

I like yours because it doesn’t require any meta-programming, but I still think my version is more readable. Only just though… I guess it’s down to taste. ;-)

Thanks for the comment.

Comment on Array matcher by Peter Harkins

Thu, 17 Jan 2008 22:18:15 +0000

I prefer to see blocks collect data instead of modifying external variables:

module Enumerable def sum ; inject(0) { |x, y| x + y }; end

def atleastone_should matches = self.collect do |item| 1 if yield item end.compact.sum matches.should >= 1 end end

But that’s overkill to test “at least one”, which I’d write: module Enumerable def atleastone_should self.each do |item| return true if yield item end return false end end

I’m not familiar with your test framework so amybe that ‘should’ test is raising something or setting a variable instead of returning true/false, but I’d rather express that I’m trying to find at least one by returning as soon as I find one. And it saves the extra checks.